New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View image button leads to encrypted-tbn0.gstatic.com #97
Comments
That's something I noticed when the current layout appeared. Edit |
Thanks for the work around, better than nothing :) |
I've made a comment yesterday, but apparently forgot to hit "comment". So here it is... After more testing it appears that the "gstatic" version of the image is used all the time when opening the side panel. Google must have modified something recently. I'll try to fix this as soon as possible. |
@psonnosp can you try this version? In TM, create a new script and paste this code. Disable the normal script, and enable this one ("BETA" is in its name).
|
Think that fixed the gstatic part, kind of hard to know for sure since it was a bit random when it appeared, but I still get a lot of data:image/jpeg;base64 links. |
When you say that you get a lot of "data:", is it still true with this version ? |
Yes, exactly as I wrote. The new version seem to have fixed the gstatic problem but I still get a lot of data:image/jpeg;base64 links. |
If you could get a couple of examples (if you can reproduce) Which browser+userJSextension are you using ? |
You know how it is when you want something to happen... I'm using Waterfox Classic and Tampermonkey. |
I don't see "data:" links from the "related" panel. The problem could be linked to how waterfox runs the code (mutationObserver and querySelector). |
The data link is in the View Image button in my provided url. What I meant about the related part is that it seems to be more common to end up with a data link in View Image if you click a related image than if you click an image among the search results to the left. Even the same image sometimes results in different outputs depending on where you click on it. [Edit] |
That's what I understood. But this behaviour is fixed by the new code in my chrome profile. So the type of browser could be an explanation (js running differently), or something that crossed my mind last night, being identified (or not) to google search.
I can explain how google search works, and how the script tries to work with it. Clicking on a thumbnail in the side panel is different. The full url is not part to these thumbnails, and when the image is displayed, its thumbnail disappears. The focused element is then the top image block on the side panel, which is structured differently. It is also modified afterwards to update the image src (not the link in this case), and the script also gets it from there with a "MutationObserver". There is sometimes an error here, when google background update fails and the url is not updated. This is the last case (at least for me) when a "gstatic" url still appears. To fix the behaviour for everyone, I'll have to check:
|
Sorry missed that you had made a post, thanks for the explanation. |
I have been running the test version successfully since then. Can you ensure that your version of the script is updated? You can delete this beta version if you had one installed in July. |
I've been running the version posted above in July since then and it has worked up until a few days ago and it has also auto updated itself yesterday but the problem is still there. |
I'll look at it in WF. I've installed it on another laptop to debug another userscript (dismissing the "sign-in" dialog). |
Follow-up If you haven't installed TM beta, you can use it to test while leaving you normal TM unmodified, in case TM is somehow faulty. (enable only the beta) |
Is that Waterfox current or classic? Realized I forgot to mention that I'm on the classic version. |
OK, so something is F'ed up in my end then, lovely... |
I can prepare a beta version, based on what I test, with more You can also check the "settings" tab of the script in TM. See if something has changed there. |
As a last resort you can install TM beta (from |
Last idea that struck me right now: what is the url of a GI page where the script doesn't work? |
@psonnosp , any news? |
Sorry, crazy times and my life is upside down so not that much time to spend at the computer. But it all seem to work again for some reason. Well not without the workaround switching images with left/right or hitting F5, but the URL is showing again. Maybe it was just Google messing around with something. Once again, thanks for your time spent on this. |
Userscript 1.5.0.12
It works on any other pages than GIS?
I'm using Waterfox so can't use anything else than the script.
https://www.google.com/search?q=jt%20leroy&tbm=isch&tbs=isz:lt,islt:2mp&hl=sv&ved=0CAEQpwVqFwoTCODHhMCTt-oCFQAAAAAdAAAAABAC&biw=1903&bih=910#imgrc=X8MAqkJVCAYUOM
Control+Shift+K
, Chrome —Ctrl+Shift+J
)The console is empty.
This doesn't happen on every image but on a lot of them.
Instead of the image URL, in this case https://metro.co.uk/wp-content/uploads/2019/08/PRI_79508760.jpg?quality=90&strip=all, the 'View Image' button links to a tiny version of the image located at encrypted-tbn0.gstatic.com and in this case https://encrypted-tbn0.gstatic.com/images?q=tbn%3AANd9GcRsvV0GQHomPdrBiS0zUTbv5j8v-BmZlae56Q&usqp=CAU
And sometimes you just get a tiny data:image/jpeg;base64 instead.
Can this be fixed?
The text was updated successfully, but these errors were encountered: